Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1533 Support Disjunctive Normal Form Types (PHP 8.2 feature) #1301

Merged
merged 2 commits into from
Nov 6, 2024
Merged

SONARPHP-1533 Support Disjunctive Normal Form Types (PHP 8.2 feature) #1301

merged 2 commits into from
Nov 6, 2024

Conversation

rudy-regazzoni-sonarsource
Copy link
Contributor

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource commented Nov 5, 2024 •
edited by jira bot
Loading

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource force-pushed the SONARPHP-1533 branch 2 times, most recently from b53de46 to 495b307 Compare November 5, 2024 15:53
jonas-wielage-sonarsource
jonas-wielage-sonarsource approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please see my comments before merging

php-frontend/src/main/java/org/sonar/php/parser/TreeFactory.java Outdated Show resolved Hide resolved
php-frontend/src/main/java/org/sonar/php/parser/TreeFactory.java Outdated Show resolved Hide resolved
php-frontend/src/main/java/org/sonar/php/parser/PHPLexicalGrammar.java Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
6 Fixed issues
10 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource merged commit 717d0fc into master Nov 6, 2024
16 checks passed
@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource deleted the SONARPHP-1533 branch November 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-wielage-sonarsource jonas-wielage-sonarsource jonas-wielage-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudy-regazzoni-sonarsource @jonas-wielage-sonarsource